The Onion Knight in Dark Souls 3 is a very long branch plot. We need to see him 5 times in total in the game, and the locations of the 5 times are also different. From the first to the final mission, there are players every time. I couldn't find where he was, so I just told him all at once.
First meeting (first time )
The first time you meet the Onion Knight is at the elevator in the Street of the Undead . He will sit in the elevator and come to the player humming a song.
(ps: This way of appearing is quite interesting and fits his character very well)

second time
The second time he was thrown into the well outside the Nether Church. We need to rescue him here (just throw his armor down).


third time
The third time I met the Onion Knight was in the sewers of Cold Rift Valley . After entering the sewers, there is a small room next to it. You can find it when you go in.


fourth time
The fourth time was in the underground prison of Irushil . He was locked in a cell at the foot of the giant . Here we need to go to the other end of the crime capital to get the cell key to rescue him.


fifth time
The last time you met the Onion Knight was in the boss room. You don't need to look for it here. Just rescue him for the fourth time and continue the plot.
